Add Lifecycle Cleanup for GitHub App Uninstallation#704
Open
pavsoss wants to merge 1 commit into
Open
Conversation
Contributor
|
@pavsoss is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds lifecycle cleanup handling for GitHub App uninstallation.
When an installation is removed, MergeShip now marks it as uninstalled, cleans up installation-scoped derived state, and prevents PR backfill jobs from continuing to process the removed installation.
The core installation record is preserved to retain historical audit context.
Changes Made
Uninstallation Cleanup
Updated
process-installation-event.tsto:uninstalled_atbefore cleanup begins.installation_repositoriesgithub_installation_usersinstallation_user_reposinstallation_settingsorg_communitiesrepo_sync_cursorsBackfill Safety
Updated
pr-backfill.tsto verify that an installation is still active before processing.The guard is applied to both:
Uninstalled or missing installations are safely skipped, while database lookup failures are surfaced so the job can retry.
Historical Data Preservation
The
github_installationsrow is not hard-deleted.Instead,
uninstalled_atis used to represent the installation lifecycle state, preserving the installation record and its historical audit context.Tests
Expanded coverage for:
Closes #700