Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Fixes around strings.#333

Open
mayukojpn wants to merge 7 commits into
Codeinwp:developmentfrom
mayukojpn:development
Open

Fixes around strings.#333
mayukojpn wants to merge 7 commits into
Codeinwp:developmentfrom
mayukojpn:development

Conversation

@mayukojpn

Copy link
Copy Markdown
Contributor

No description provided.

@ineagu

ineagu commented Apr 18, 2016

Copy link
Copy Markdown
Contributor

@mayukojpn hey there, thanks again for help! I think the screen-reader-text things are required for accessibility purpose.

@ineagu

ineagu commented Apr 18, 2016

Copy link
Copy Markdown
Contributor

Also we might take some time to merge this since we are planning to merge all string related things once in few months :)

@mayukojpn

Copy link
Copy Markdown
Contributor Author

OK, I cancelled these fixes :)

In this case, I'd like to translatie both "Install %s now" and "Install Now". If there are no theme name, we should remove particle (Like to, on, in ...)

@ineagu

ineagu commented Apr 18, 2016

Copy link
Copy Markdown
Contributor

yep got it, however just a general thought, I don't think we should have product names translatable, I mean Zerif Lite for example is a brand and a trademark, you don't translate that.

I mean do you translate WordPress in other languages? In romanian would be : cuvantpresa 👯

@mayukojpn

Copy link
Copy Markdown
Contributor Author

No, we don't translate WordPress. Sometimes we translate theme/plugin name depending on author's request, but these are rare.

Sometimes we write WordPress as "ワードプレス", but pronunciation is almost same (a bit harder sound 😃).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants