feat!: remove deprecated scss mixins and variables#3340
Draft
aresnik11 wants to merge 7 commits into
Draft
Conversation
|
View your CI Pipeline Execution ↗ for commit 9111a25 ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
- Coverage 90.40% 89.91% -0.50%
==========================================
Files 405 276 -129
Lines 6649 5730 -919
Branches 2125 1933 -192
==========================================
- Hits 6011 5152 -859
+ Misses 630 570 -60
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
📬 Published Alpha Packages:
|
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a02272bcb0acba57ddc968f--gamut-preview.netlify.app |
aresnik11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove legacy
@codecademy/gamut-stylesSCSS utilitiesThis branch deletes the shared SCSS “utils” layer from
gamut-styles: functions, mixins, variable partials, and the barrel files that forwarded them.core/_reboot.scssis updated so core still works without the old variable/mixin pipeline.Downstream impact: Any app or package that did
@use "~@codecademy/gamut-styles/utils"(or relied on those mixins / SCSS color grids / responsive helpers) must either be updated to use the plain CSS values, add a shared utils in the app/package for the mixins/variables needed, or refactored to use the equivalent TypeScript / Emotion APIs.Gamut components still on SCSS
Remaining SCSS in Gamut that used the removed utils is rewritten to plain CSS values (or self-contained rules), including:
AccordionButtonDeprecated(andButtonDeprecatedunder it):variables.scss,mixins.scss, andindex.module.scssupdated so they no longer depend on removedgamut-stylesSCSS.Video(vds_base_theme.scss): removepx-remfunction in alignment with the cleanup.Typography/_variables.scss: removed where it was only supporting the old SCSS token path.Docs
Utilities.mdx: SCSS examples (px-rem,@include box-shadow,@include font-smoothing, etc.) removed; headings emphasize TS-only helpers (pxRem,boxShadow,fontSmoothing, …).gamut-stylesREADME: trimmed to match the new surface area.PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs