Skip to content

London | 26-Mar-SDC | Onur Atas | Sprint 5| prep exercises#532

Open
onurat wants to merge 3 commits into
CodeYourFuture:mainfrom
onurat:sprint-5-prep
Open

London | 26-Mar-SDC | Onur Atas | Sprint 5| prep exercises#532
onurat wants to merge 3 commits into
CodeYourFuture:mainfrom
onurat:sprint-5-prep

Conversation

@onurat
Copy link
Copy Markdown

@onurat onurat commented May 29, 2026

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x] My changes meet the requirements of the task
  • [ x] I have tested my changes
  • [ x] My changes follow the style guide

Changelist

Completed all Sprint 5 prep exercises:

  • Why we use types
  • Type checking with mypy
  • Classes and objects
  • Methods
  • Dataclasses
  • Generics
  • Type-guided refactorings
  • Enums
  • Inheritance

Tested all exercises locally.

Note: person_class.py intentionally contains an invalid property access (person.address) because the exercise required demonstrating that mypy can detect access to a property that does not exist.

@onurat onurat added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
Copy link
Copy Markdown
Contributor

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have submitted the wrong files here, do you want to take another look?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
@onurat
Copy link
Copy Markdown
Author

onurat commented Jun 3, 2026

I made a mistake on the branching. This has all that's been done so far for the tools module. I believe only the prep exercises folder needs reviewing. Or you can look at this commit sha 0b59f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants