London | 26-Mar-SDC | Onur Atas | Sprint 3| Implement shell tools#518
Open
onurat wants to merge 3 commits into
Open
London | 26-Mar-SDC | Onur Atas | Sprint 3| Implement shell tools#518onurat wants to merge 3 commits into
onurat wants to merge 3 commits into
Conversation
Complete ls implementation with -1 and -a support
Complete Module Tools: ls, cat, wc implementations
onurat
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks
Across your solutions you manually check for options in the input arguments. Do you know of any library based solutions that could help build program argument handling that is a bit easier to manage? It would also let you add help text, and combine single letter arguments together like you can on the command line.
See also my other remarks.
|
|
||
| const args = process.argv.slice(2); | ||
|
|
||
| const showAll = args.includes("-a"); |
Contributor
There was a problem hiding this comment.
This task also wants you to handle the -1 argument. Can you try that?
|
|
||
| let output = []; | ||
|
|
||
| if (showLines) output.push(format(stats.lines)); |
Contributor
There was a problem hiding this comment.
This pattern of code is repeated, is there any way you can reduce that?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Implemented ls, cat, and wc in Node.js by manually parsing CLI arguments and replicating core Unix command behaviour.