-
-
Notifications
You must be signed in to change notification settings - Fork 92
London | 26-SDC-March | Zobeir Rigi | Sprint 3 | implement-shell-tools #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zobeir-Rigi
wants to merge
10
commits into
CodeYourFuture:main
Choose a base branch
from
Zobeir-Rigi:implement-shell-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cd7ccde
Add cat.js
Zobeir-Rigi 699913a
we need to split the string by the /n, and then get the length
Zobeir-Rigi b766aad
Add basic cat to read and print file contents
Zobeir-Rigi dba8fd3
Add -n flag to number all lines
Zobeir-Rigi 637b764
Add -b flag to number non-empty lines
Zobeir-Rigi adea241
Add basic ls command with -1 support, ls is readdir
Zobeir-Rigi c0a4dca
Add -a flag to show hidden files
Zobeir-Rigi 4e1c717
Add basic wc for single file lines, words, chars
Zobeir-Rigi d2e94fc
Support multiple files in wc
Zobeir-Rigi 43510be
Add -l -w -c flags to wc
Zobeir-Rigi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import process from "node:process"; | ||
| import { promises as fs } from "node:fs"; | ||
|
|
||
| const args = process.argv.slice(2); | ||
|
|
||
| let option = "none"; | ||
| const paths = []; | ||
|
|
||
|
|
||
| for (const arg of args) { | ||
| if (arg === "-n") { | ||
| option = "n"; | ||
| } else if (arg === "-b") { | ||
| option = "b"; | ||
| } else { | ||
| paths.push(arg); | ||
| } | ||
| } | ||
|
|
||
| if (paths.length === 0) { | ||
| console.error("Expected at least one file path."); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| for (const path of paths) { | ||
| const content = await fs.readFile(path, "utf-8"); | ||
|
|
||
| const lines = content.split("\n"); | ||
|
|
||
| let lineNumber = 1; | ||
|
|
||
| for (const line of lines) { | ||
|
|
||
| if (option === "n") { | ||
| console.log(`${lineNumber} ${line}`); | ||
| lineNumber++; | ||
| } | ||
|
|
||
| else if (option === "b") { | ||
|
|
||
| if (line !== "") { | ||
| console.log(`${lineNumber} ${line}`); | ||
| lineNumber++; | ||
| } else { | ||
| console.log(""); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| else { | ||
| console.log(line); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import process from "node:process"; | ||
| import { promises as fs } from "node:fs"; | ||
|
|
||
| const args = process.argv.slice(2); | ||
|
|
||
| let showAll = false; | ||
| let path = "."; | ||
|
|
||
| for (const arg of args) { | ||
|
|
||
| if (arg === "-a") { | ||
| showAll = true; | ||
| } | ||
|
|
||
| else if (arg !== "-1") { | ||
| path = arg; | ||
| } | ||
| } | ||
|
|
||
| const files = await fs.readdir(path); | ||
|
|
||
| for (const file of files) { | ||
|
|
||
| if (!showAll && file.startsWith(".")) { | ||
| continue; | ||
| } | ||
|
|
||
| console.log(file); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import process from "node:process"; | ||
| import { promises as fs } from "node:fs"; | ||
|
|
||
| const args = process.argv.slice(2); | ||
|
|
||
| let option = "all"; | ||
| const paths = []; | ||
|
|
||
| // parse args | ||
| for (const arg of args) { | ||
| if (arg === "-l") option = "l"; | ||
| else if (arg === "-w") option = "w"; | ||
| else if (arg === "-c") option = "c"; | ||
| else paths.push(arg); | ||
| } | ||
|
|
||
| if (paths.length === 0) { | ||
| console.error("Please provide at least one file"); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| for (const path of paths) { | ||
| const content = await fs.readFile(path, "utf-8"); | ||
|
|
||
| const lines = content.split("\n").length; | ||
| const words = content.split(" ").length; | ||
| const chars = content.length; | ||
|
|
||
| if (option === "l") { | ||
| console.log(lines, path); | ||
| } else if (option === "w") { | ||
| console.log(words, path); | ||
| } else if (option === "c") { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are using else if here. What if someone wanted words and chars but not lines? |
||
| console.log(chars, path); | ||
| } else { | ||
| console.log(lines, words, chars, path); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you correctly handling the -1 argument?