London | 26-SDC-Mar | Beko | Sprint 4 | Implement Shell Tools#501
Open
Abubakar-Meigag wants to merge 3 commits into
Open
London | 26-SDC-Mar | Beko | Sprint 4 | Implement Shell Tools#501Abubakar-Meigag wants to merge 3 commits into
Abubakar-Meigag wants to merge 3 commits into
Conversation
Abubakar-Meigag
added
📅 Sprint 4
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but there is some work left to do here.
Is there a package you could use to help with managing arguments? Right now it doesn't offer any help text, and you can't combine single-letter arguments like the command line tools.
LonMcGregor
added
Reviewed
Implement -1 for the ls file exercises
Abubakar-Meigag
added
Needs Review
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great. One one other thing I have noticed is there is a lot of repetition in the structure at the end of the word counts file. Can you find a way to reduce that duplication?
LonMcGregor
added
Reviewed
update for code review
Abubakar-Meigag
added
Needs Review
Contributor
Author
it's done now, you could check it, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Complete shell tools exercises for sprint 4 in Python