fix: prevent activation fatal when installed without vendor/ - #2
Open
mboss97 wants to merge 1 commit into
Open
Conversation
The bootstrap loaded the PSR-4 AssetDrips\ namespace only through Composer's
vendor/autoload.php, guarded by is_readable(). A distributed zip that shipped
without a vendor/ directory therefore loaded no classes, and activation fataled:
Uncaught Error: Class "AssetDrips\Db\Schema" not found in assetdrips.php:48
The plugin has no third-party runtime dependencies, so the autoloader's only
runtime job is mapping AssetDrips\ -> src/. Register a minimal built-in PSR-4
autoloader as a fallback when vendor/autoload.php is absent, making the plugin
self-contained regardless of how it is packaged.
Fixes CodeDrips#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootstrap loaded the PSR-4 AssetDrips\ namespace only through Composer's vendor/autoload.php, guarded by is_readable(). A distributed zip that shipped without a vendor/ directory therefore loaded no classes, and activation fataled:
The plugin has no third-party runtime dependencies, so the autoloader's only runtime job is mapping AssetDrips\ -> src/. Register a minimal built-in PSR-4 autoloader as a fallback when vendor/autoload.php is absent, making the plugin self-contained regardless of how it is packaged.
Fixes #1
What does this PR do?
Related issue
Type of change
Checklist
composer testpasses locallycomposer lintis clean for the code I changedNotes for reviewers