fix(session): share auth state via SessionProvider to stop redirect loop#239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The role guard in (app)/_layout redirects manager/staff away from the admin tab, which the tab navigator restores from the previous session. Each redirect remounted the layout with a fresh useSession() stuck back at 'loading'; the layout renders null while loading, unmounting its own before the navigation landed — an endless loop that left the app on a blank screen with
no error.
Hoist the session into a SessionProvider mounted at the root layout so it resolves once and never falls back to 'loading' on remount, and swallow a rejected getSession() instead of hanging in 'loading' forever.