fix(posts): embed author via profiles_public so staff can load the feed#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profiles RLS hardening (20260703000000) restricted SELECT to own row for staff, but listPublishedPosts and getPostById still embedded profiles!author_id directly. For staff every post came back with author: null, and PostCard / the post detail read post.author.name unguarded — the render threw and the Tablón never painted.
Embed the author through the profiles_public view (same path already used by lib/comments.ts), mark author as nullable and access it defensively so an orphaned author renders "—" instead of crashing the screen.