π‘οΈ Sentinel: [CRITICAL] Fix command injection in terminal service - #169
Conversation
Replaced execSync with execFileSync when running sudo chown in terminal service to prevent command injection from user-controlled chownTo input.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection vulnerability in
apps/agor-daemon/src/services/terminals.tswhere user-controlled input (chownTo) was interpolated directly into a shell command executed viaexecSyncwithsudo.π― Impact: Potential root privilege escalation since the command is executed with
sudo.π§ Fix: Replaced
execSyncwithexecFileSyncand parameterized arguments, casting them to String and prepending--.β Verification: Ran
pnpm -w run lint:fixandpnpm --filter @agor/daemon testto confirm tests pass and no regression introduced. Updated Sentinel journal with learnings.PR created automatically by Jules for task 18401671691682093998 started by @Donach