Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in terminal service - #169

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-chown-command-injection-18401671691682093998
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in terminal service#169
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-chown-command-injection-18401671691682093998

Conversation

@Donach

@Donach Donach commented Aug 4, 2026

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command injection vulnerability in apps/agor-daemon/src/services/terminals.ts where user-controlled input (chownTo) was interpolated directly into a shell command executed via execSync with sudo.
🎯 Impact: Potential root privilege escalation since the command is executed with sudo.
πŸ”§ Fix: Replaced execSync with execFileSync and parameterized arguments, casting them to String and prepending --.
βœ… Verification: Ran pnpm -w run lint:fix and pnpm --filter @agor/daemon test to confirm tests pass and no regression introduced. Updated Sentinel journal with learnings.


PR created automatically by Jules for task 18401671691682093998 started by @Donach

Replaced execSync with execFileSync when running sudo chown in terminal
service to prevent command injection from user-controlled chownTo input.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant