🛡️ Sentinel: [CRITICAL] Fix SQL injection risk in JSON extraction - #160
Conversation
Fixes a potential SQL injection vulnerability in `jsonExtract` located inside `packages/core/src/db/database-wrapper.ts`.
The original implementation used `sql.raw` to construct dynamic JSON path string accesses in PostgreSQL, which bypassed parameterization and made it vulnerable to SQL injection.
The fix explicitly casts dynamic parameters to `text` using `::text` along with proper interpolation via Drizzle ORM's `sql` template literal string syntax (e.g., `sql\`->> (${key}::text)\``). This maintains safe query parameterization while avoiding Postgres operator overload ambiguity.
Also added an entry in `.jules/sentinel.md` outlining the findings and required secure practices.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Unparameterized JSON path accesses via
sql.rawinjsonExtract(packages/core/src/db/database-wrapper.ts). Any caller passing dynamic inputs into this function as JSON path accesses was vulnerable to SQL injection.🎯 Impact: Allowed execution of arbitrary SQL commands, resulting in potential data leaks, corruption, or denial of service by manipulating JSON path variables.
🔧 Fix: Changed the dynamic construction of Postgres JSON queries to use parameterized template literals with explicit Postgres type casting (
::text), avoidingsql.raw.✅ Verification: Ran test suite, linter, and confirmed that string values are safely parameterized in
test-sql.js(a scratchpad verification run in bash) where->>extracts now emit query chunks instead of concatenating raw SQL string values.PR created automatically by Jules for task 9349292083475052799 started by @Donach