π‘οΈ Sentinel: [CRITICAL] Fix SQL injection in database-wrapper - #158
π‘οΈ Sentinel: [CRITICAL] Fix SQL injection in database-wrapper#158Donach wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: A SQL injection vulnerability existed in
packages/core/src/db/database-wrapper.tswherejsonExtractusedsql.rawto construct JSON path expressions.π― Impact: By interpolating string values into
sql.raw, it bypassed Drizzle's parameterization, exposing the app to SQL injection if user input were passed as a path key.π§ Fix: Replaced
sql.rawwith explicit text casting of dynamic parameters (e.g.,sql\->> (${key}::text)`) to properly resolve the overloaded operator type and ensure Drizzle uses parameterized queries. β Verification: Ranpnpm testandpnpm lint:fixlocally. The generated Drizzle query now correctly uses$1::text` instead of string concatenation.PR created automatically by Jules for task 8185999169587583444 started by @Donach