Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection in database-wrapper - #158

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
fix/sql-injection-json-extract-8185999169587583444
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection in database-wrapper#158
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
fix/sql-injection-json-extract-8185999169587583444

Conversation

@Donach

@Donach Donach commented Jul 28, 2026

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: A SQL injection vulnerability existed in packages/core/src/db/database-wrapper.ts where jsonExtract used sql.raw to construct JSON path expressions.
🎯 Impact: By interpolating string values into sql.raw, it bypassed Drizzle's parameterization, exposing the app to SQL injection if user input were passed as a path key.
πŸ”§ Fix: Replaced sql.raw with explicit text casting of dynamic parameters (e.g., sql\->> (${key}::text)`) to properly resolve the overloaded operator type and ensure Drizzle uses parameterized queries. βœ… Verification: Ran pnpm testandpnpm lint:fixlocally. The generated Drizzle query now correctly uses$1::text` instead of string concatenation.


PR created automatically by Jules for task 8185999169587583444 started by @Donach

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant