Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in ID lookups - #157

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-id-lookup-command-injection-8323551273461768723
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in ID lookups#157
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-id-lookup-command-injection-8323551273461768723

Conversation

@Donach

@Donach Donach commented Jul 27, 2026

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Shell command injection vulnerability in packages/core/src/unix/id-lookups.ts. User-controlled inputs (username and groupName) were passed to execSync via string interpolation, allowing an attacker to inject arbitrary shell commands.
🎯 Impact: Remote code execution (RCE) with the privileges of the daemon process.
πŸ”§ Fix:

  • Replaced execSync with execFileSync to execute commands directly without a shell interpreter.
  • Passed user inputs as arguments in an array instead of concatenating strings.
  • Used the POSIX -- delimiter before user inputs (e.g., ['passwd', '--', username]) to strictly separate options from arguments, protecting against flag/argument injection.
  • Updated .jules/sentinel.md journal with the learning to use execFileSync over execSync for dynamic arguments.
    βœ… Verification:
  • pnpm -w run lint:fix succeeds with no formatting issues.
  • pnpm --filter @agor/core test -- src/unix passes all unit tests for the core package.

PR created automatically by Jules for task 8323551273461768723 started by @Donach

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant