π‘οΈ Sentinel: [CRITICAL] Fix SQL injection in jsonExtract - #156
π‘οΈ Sentinel: [CRITICAL] Fix SQL injection in jsonExtract#156Donach wants to merge 1 commit into
Conversation
Replaced unparameterized `sql.raw` with type-safe `sql` tagged template literals in `packages/core/src/db/database-wrapper.ts`.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: In
jsonExtractlocated insidepackages/core/src/db/database-wrapper.ts, the code was joining strings utilizingsql.rawto fetch deep fields using PostgreSQL's JSON path operators->and->>. This method bypasses Drizzle ORM's parameterized statements, exposing the database to SQL injection attacks if any JSON key/path comes from an unvalidated or manipulated string.π― Impact: If any JSON path argument is manipulated, it could let an attacker break out of the query boundary and execute arbitrary SQL commands on the database, allowing unauthorized data access, modification, or potential privilege escalation.
π§ Fix: Substituted the manual
sql.rawinterpolation with Drizzle's native parameterizedsqltemplate literal string syntax. The change correctly utilizes explicit text casting (e.g.,sql\->> (${parts[0]}::text)``) to satisfy PostgreSQL's overloaded JSON operators, protecting against SQL injection without regressing application behavior.β Verification:
pnpm lint:fix.@agor/coreincludingsrc/db/client.test.tscompleted correctly.PR created automatically by Jules for task 9662609264979514183 started by @Donach