π‘οΈ Sentinel: [CRITICAL] Fix command injection in ID lookups - #154
Conversation
Replace execSync with execFileSync and parameterize arguments in id-lookups.ts to prevent shell command injection via dynamic usernames or group names.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection vulnerability in
packages/core/src/unix/id-lookups.ts. The code usedexecSyncwith string interpolation (e.g.,execSync(\getent group "${groupName}"`)), allowing malicious input in usernames or group names to execute arbitrary shell commands. π― **Impact:** If an attacker can control the username or group name input, they could execute arbitrary shell commands on the host system. π§ **Fix:** ReplacedexecSyncwithexecFileSyncand parameterized arguments (e.g.,execFileSync('getent', ['group', '--', String(groupName)])). Using--prevents argument injection. This prevents the shell from parsing user inputs as commands. β **Verification:** Verified by runningpnpm -w run lint:fixandpnpm --filter @agor/core test -- src/unix/user-manager.test.ts. Added a journal entry to.jules/sentinel.md`.PR created automatically by Jules for task 4600681115705557771 started by @Donach