Skip to content

⚡ Bolt: [Performance] Eliminate N+1 query when fetching MCP OAuth tokens - #150

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt-fix-mcp-oauth-token-n1-4391492376335122933
Open

⚡ Bolt: [Performance] Eliminate N+1 query when fetching MCP OAuth tokens#150
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt-fix-mcp-oauth-token-n1-4391492376335122933

Conversation

@Donach

@Donach Donach commented Jul 22, 2026

Copy link
Copy Markdown

💡 What:
Replaced individual database queries for MCP server OAuth tokens inside an after hook map loop with a single batched lookup using inArray. The results are loaded into an in-memory Map for O(1) retrieval during the enrichment step.

🎯 Why:
Previously, resolving OAuth tokens for a list of MCP servers (like in agor_mcp_servers_list) caused an N+1 query problem, making a separate database round-trip for every server in the result set.

📊 Impact:
Reduces database round-trips from O(N) to O(1) when fetching multiple MCP servers, significantly decreasing latency and database load for large server lists.

🔬 Measurement:
Monitor database query counts and response times for the /mcp-servers API endpoints (or MCP tools that return server lists). You should see a reduction in the number of sequential SELECT queries against user_mcp_oauth_tokens.


PR created automatically by Jules for task 4391492376335122933 started by @Donach

* Added `getTokensForServers` batched lookup to `UserMCPOAuthTokenRepository`.
* Refactored `injectPerUserOAuthTokens` hook in `register-hooks.ts` to fetch all necessary tokens upfront and map them by `serverId:userId`.
* Avoids repeated database roundtrips when loading multiple MCP servers.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant