⚡ Bolt: Batch MCP OAuth token fetches to fix N+1 query - #147
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Implemented
getTokensForServersinUserMCPOAuthTokenRepositoryand updatedinjectPerUserOAuthTokenshook to batch load tokens and map them via an in-memory Map using compound keys.🎯 Why: Solved an N+1 query problem where the FeathersJS hook fetched OAuth tokens iteratively inside a
Promise.allloop for each MCP server in the result.📊 Impact: Reduces database queries from O(N) to O(1) (2 batched queries) during MCP server list retrieval.
🔬 Measurement: Check the database logs during a request to
/session-mcp-serversor/mcp-serverswith a list of servers to ensure only twoSELECTstatements are executed for tokens rather than one for each server.PR created automatically by Jules for task 2233015174498339841 started by @Donach