🛡️ Sentinel: [CRITICAL] Fix SQL injection in jsonExtract parameterization - #146
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: CRITICAL
💡 Vulnerability: The
jsonExtracthelper indatabase-wrapper.tsusedsql.rawto interpolate JSON paths. This bypasses Drizzle's parameterization, exposing the database to SQL injection if dynamic, unvalidated keys are passed as paths.🎯 Impact: An attacker could supply malicious strings to a JSON path resulting in SQL syntax manipulation and potential extraction or modification of sensitive database content.
🔧 Fix: Replaced
sql.rawmanual interpolation with parameterized queries usingsql\->> (${key}::text)`andsql.jointo safely concatenate paths. The::textcast solves parameterization typing issues while maintaining safety. ✅ Verification: Runpnpm -w run lint:fixandpnpm --filter @agor/core test` to ensure tests pass and verify the query executes securely.PR created automatically by Jules for task 11315107737218491476 started by @Donach