200 project card#207
Conversation
tsudhakar87
left a comment
tsudhakar87
left a comment
There was a problem hiding this comment.
looks solid! just some minor things I noticed when testing locally
| <RxPeople /> | ||
| <h5 className="!font-bold">Staff</h5> | ||
| </div> | ||
| <p className="truncate">{members} members</p> |
There was a problem hiding this comment.
(nit) should this also be members.toLocaleString()?
| <div className="w-full !h-[24px] rounded-full bg-black-100"> | ||
| <div className={`w-[${percentage}%] !h-full rounded-full bg-core-green`} /> | ||
| </div> | ||
| <p>30%</p> |
There was a problem hiding this comment.
is this meant to be hardcoded (?) (can replace w {percentage}%)
| </div> | ||
| <div className="flex flex-row items-center !gap-2"> | ||
| <div className="w-full !h-[24px] rounded-full bg-black-100"> | ||
| <div className={`w-[${percentage}%] !h-full rounded-full bg-core-green`} /> |
There was a problem hiding this comment.
I think this isn't applying the percentage to the class bc it's interpreting it as a template literal and can't determine the value, so you could add it as separate styling via <div style={{ width: `${percentage}%`` }} className="!h-full rounded-full bg-core-green" /> so that it adjusts the progress bar width properly!
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Echoing thillai's comments and also, thoughts on making this one component with a prop for whether it's archived or not? Or alternatively extracting out the shared portions (maybe just the top right corner Staff section)? Just want to make sure we don't have to maintain things in 2 places
Otherwise looks great!
3 participants
ℹ️ Issue
#200
📝 Description
Created project card components for both active and archived project cards
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!