fix: account for the View's scroll value in the previewBox calculation#11
Open
Mufanc wants to merge 1 commit into
Open
fix: account for the View's scroll value in the previewBox calculation#11Mufanc wants to merge 1 commit into
Mufanc wants to merge 1 commit into
Conversation
Contributor
Author
|
There also seem to be some issues with the rendering I need to make further adjustments. |
Contributor
Author
|
It appears the issue wasn't introduced by my changes. reverting to the old code also encounters incorrect device screenshots in certain cases. The cause remains unidentified. I will investigate further and open a new pull request once the cause is determined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the previewBox calculation did not account for the View's scroll value which would lead to incorrect coordinate calculations in scenarios like ViewPager.