Fix async shutdown for SkyKettle connection - #92
Merged
Conversation
IvanGerr
force-pushed
the
codex/fix-async-stop-shutdown
branch
from
March 30, 2026 21:35
b5a9a3b to
427da5c
Compare
ClusterM
approved these changes
Mar 31, 2026
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the integration shutdown path for
KettleConnection.stop()currently calls the async_disconnect()method without awaiting it, and the unload path runsstop()in an executor. As a result, the BLE disconnect coroutine is never actually awaited during config flow cleanup or entry unload.This patch makes
stop()async, awaitsdisconnect(), clears any pending target state during disposal, and updates both call sites to awaitstop()directly.