Support hotkey re-registration on keyboard key code changes#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoReRegisterOnKeyboardKeyCodesChangeflag toHotKeyNSNotification.Name.SauceSelectedKeyboardKeyCodesChangedand re-register only enabled hot keys whose stored key code no longer matches the current input sourceWhy
macOS registers the layout-specific key code that is current at registration time. For example, registering
vuses KeyCode9on a QWERTY layout, but KeyCode47on a Dvorak layout. If the selected keyboard key codes change later, the registered hot key can stop pointing at the intended physical key unless it is registered again.Impact
Existing behavior is unchanged by default. Callers can opt in per hot key when they want automatic re-registration on keyboard key code changes.
Validation
swift test