Use SF Symbol for clear button#87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the custom clear button drawing with an AppKit
NSButtonthat uses thexmark.circle.fillSF Symbol. The button now uses semantic tinting throughtertiaryLabelColor, so it follows system appearance changes instead of relying on fixed RGB colors.This also removes the now-unused custom
ClearButtonclass and color extension, and updates the Xcode project source list accordingly.Impact
The clear button keeps the same role in
RecordViewwhile relying on system-provided symbol rendering. This reduces custom drawing code and improves dark mode behavior.Checked locally with
swift buildandxcodebuild -project Lib/KeyHolder.xcodeproj -scheme KeyHolder -configuration Debug -derivedDataPath /private/tmp/KeyHolderDerivedData build.