Skip to content

New. Integration. Integration with Email Subscribers#809

Open
AntonV1211 wants to merge 4 commits into
devfrom
new_integ_email_sub_av
Open

New. Integration. Integration with Email Subscribers#809
AntonV1211 wants to merge 4 commits into
devfrom
new_integ_email_sub_av

Conversation

@AntonV1211

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings June 9, 2026 06:18
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.35%. Comparing base (a1cd3fa) to head (cb88a98).
⚠️ Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...eantalk/Antispam/Integrations/EmailSubscribers.php 54.54% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (64.28%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #809      +/-   ##
============================================
+ Coverage     26.25%   26.35%   +0.09%     
- Complexity     5632     5647      +15     
============================================
  Files           265      266       +1     
  Lines         24160    24184      +24     
============================================
+ Hits           6344     6373      +29     
+ Misses        17816    17811       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated CleanTalk integration for the Email Subscribers by Icegram Express plugin, moving handling from the generic AJAX hook into the integrations-by-hook framework.

Changes:

  • Introduces Cleantalk\Antispam\Integrations\EmailSubscribers to collect subscription POST data and return a standardized block JSON payload.
  • Registers the new integration in inc/cleantalk-integrations-by-hook.php for the es_add_subscriber AJAX action.
  • Removes the legacy es_add_subscriber special-case from ct_ajax_hook().

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
lib/Cleantalk/Antispam/Integrations/EmailSubscribers.php New integration implementation: data extraction + AJAX block response.
inc/cleantalk-pluggable.php Adds a skip rule for es_add_subscriber when Email Subscribers is active.
inc/cleantalk-integrations-by-hook.php Registers EmailSubscribers integration on es_add_subscriber (AJAX).
inc/cleantalk-ajax.php Removes legacy hardcoded handling for es_add_subscriber.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/Cleantalk/Antispam/Integrations/EmailSubscribers.php Outdated
Comment thread lib/Cleantalk/Antispam/Integrations/EmailSubscribers.php
Copilot AI review requested due to automatic review settings June 9, 2026 06:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment on lines +1748 to +1754
// Email Subscribers by Icegram Express - skip subscribe action
if (
apbct_is_plugin_active('email-subscribers/email-subscribers.php') &&
Post::equal('action', 'es_add_subscriber')
) {
return 'Email Subscribers by Icegram Express - skip subscribe action';
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants