fix: MSYS2 build compatibility on Windows#1503
Open
7ayun wants to merge 1 commit into
Open
Conversation
- Remove EXACT version constraint from Boost find_package to allow newer Boost versions (e.g. 1.91.0) installed via MSYS2 - Fix AMD H.264 encoder compile error: cfg.profile field does not exist in config_t struct, hardcode high profile instead - Fix Web UI build failure on Windows: add npm_config_scripts_prepend_node_path=true env var so npm subprocesses can locate node.exe in PATH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several build issues encountered when building Apollo on Windows using MSYS2 UCRT64.
Changes
cmake/dependencies/Boost_Sunshine.cmake
Remove the version constraint from . MSYS2 ships Boost 1.91.0 but the cmake script required exactly 1.89.0, causing the build to fall back to FetchContent unnecessarily. Removing allows any compatible version to be used.
src/video.cpp
Fix compile error in AMD H.264 encoder options: does not exist in struct. Hardcode profile as the constant value since the field is unavailable.
cmake/targets/common.cmake
Fix Web UI build failure on Windows: when CMake spawns Microsoft Windows [Version 10.0.26200.8457]
(c) Microsoft Corporation. All rights reserved.
C:\Users\re\Desktop\Workspace> subprocesses to run npm, the subprocesses cannot find in PATH. Adding instructs npm to automatically prepend the Node.js directory to PATH for all script invocations.
Test Environment