feature(audio): release audio sink on client pause#1465
Conversation
f91e087 to
59df475
Compare
59df475 to
60e9cf9
Compare
|
Thank you but why change the title? Technically you should only release it when paused, which means all clients are disconnected. |
the short answer is, I was arguing with myself about semantics. I was concerned about conflating the two concepts. For my use case, I am “pausing” with pause.ahk, but likely a majority of users don’t use the ahk scripts to pause, they disconnect but keep the session alive. So I was making sure not to conflate the two and keep the language neutral and not break expected behavior without scripts. but the process is indeed “paused”, so I had it right the first time. reverted title back to pause. |
I was going crazy trying to figure out why the PC refused to sleep (thread) while using your AHK sleep scripts and realized it's one of 2 things:
This change introduces a fix for the second bullet point. It releases the audio driver when all clients disconnect, so it no longer prevents the PC from sleeping.
I've tested these changes on my local machine for over a week now using my own personal AHK script (still needs work) that freezes and minimizes the game, allowing the host PC to sleep on disconnect!
Trying not to go too deep into the AHK script specifics on this audio sink PR, but thought it was relevant to understanding why I want this change.
This is an opt-in feature. original behavior is preserved by default.