Fix snapshot bootstrap for short generations - #95
Conversation
|
HOLD — do not merge. This PR (snapshot bootstrap fix for short generations) is merge-gated pending reconciliation with the KHA-398 cold-tier restore work, which lives in the same scheduler snapshot/restore/prefix path. Merging blind risks conflicting with or silently breaking that work. Convert to draft until the cross-compare is done. The temporary tokenize admin-key auth loosening is NOT in this PR and must never be merged. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Review NotesThe PR correctly fixes snapshot bootstrap for short generations by ensuring Mamba state is persisted before request pool slots are released:
Fork-specific concerns (Engram):
Files Reviewed (2 files)
Reviewed by minimax-m2.7 · 243,189 tokens |
Summary
Verification
PYTHONPATH=/workspace/engram-remote-elastic-30b/python python -m py_compile /workspace/engram-remote-elastic-30b/python/sglang/srt/managers/scheduler_components/batch_result_processor.py /workspace/engram-remote-elastic-30b/python/sglang/srt/managers/scheduler.py /workspace/engram-remote-elastic-30b/python/sglang/srt/utils/auth.pyPYTHONPATH=/workspace/engram-remote-elastic-30b/python python -m pytest /workspace/engram-remote-elastic-30b/test/registered/unit/utils/test_auth.py -qmax_tokens: 1returnedThor;/save_snapshotreturnedsuccess:true;/list_snapshotsshowed turn 1 undershort-bootstrap-040001Note
Temporary auth loosening for the demo instance is intentionally not included in this PR.
CI States
Latest PR Test (Base): ❌ Run #26386031478
Latest PR Test (Extra): ❌ Run #26386030063