Skip to content

Vote Result Preprocessor#125

Open
qedi-r wants to merge 3 commits into
CivicTechWR:masterfrom
qedi-r:preprocessor
Open

Vote Result Preprocessor#125
qedi-r wants to merge 3 commits into
CivicTechWR:masterfrom
qedi-r:preprocessor

Conversation

@qedi-r
Copy link
Copy Markdown
Contributor

@qedi-r qedi-r commented Mar 22, 2026

Some background: I initially thought this would be required to build the other PR I am submitting, but in the end it ended up simpler than intended. However, in this case, for the results, it greatly simplified the templates, and is a more natural pattern for pre-processing the csv for anything more complex in the future, so I think it is worth including.

@qedi-r qedi-r changed the title Preprocessor Vote Result Preprocessor Mar 22, 2026
@pnijjar
Copy link
Copy Markdown
Contributor

pnijjar commented Mar 22, 2026 via email

@pnijjar
Copy link
Copy Markdown
Contributor

pnijjar commented Mar 22, 2026 via email

@qedi-r
Copy link
Copy Markdown
Contributor Author

qedi-r commented Mar 22, 2026

Oh, shoot. Well, if GH pages doesn't support the plugin, we can put a pin on it for now. I'll investigate if we can do more with actions or not.

@qedi-r
Copy link
Copy Markdown
Contributor Author

qedi-r commented Mar 23, 2026

FWIW, building with GH Actions would execute the preprocessor. I think it's easier to manage, easier to read and write, but also it's just a marginal improvement.

Like I said, I thought it would get complex for the tags, but really, it wasn't. Vote counting and sorting is probably the most complex we have, mainly because of the re-ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants