feat: add IQN pool reservation support#341
Open
stevefulme1 wants to merge 1 commit into
Open
Conversation
Add iqn pool type to POOL_TYPE_MAP targeting /iqnpool/Reservations and /iqnpool/Pools endpoints. Includes unit test for IQN reservation body construction and integration test target mirroring existing IP pool reservation test structure. Ref: ACA-4997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iqnpool type tointersight_pool_reservationmodule, targeting/iqnpool/Reservationsand/iqnpool/PoolsAPI endpointsTest plan
test_iqn_reservationvalidates POST body has correctObjectType: iqnpool.Reservation,Identity, and noIdPurposetest_all_pool_types_mappedverifies all 6 pool types present inPOOL_TYPE_MAPRef: ACA-4997