feat(release): Windows MSIX + App Installer auto-update — pipeline (ADR 0034, 1/2)#92
Merged
Merged
Conversation
…no phone-home) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… 0034) Pivot the Windows artifact from cargo-packager NSIS .exe to an MSIX that auto-updates via Windows App Installer, signed by the existing Azure Trusted Signing cert (no second key). Slice (a) of two: the packaging pipeline. The in-app "Check for updates" button (the sole, manual-only update trigger) is slice (b), a follow-up PR. - release.yml: rewrite the `windows` job - build exe, assemble the pack layout, `makeappx pack`, Trusted-Sign the .msix, upload .msix + .appinstaller. The verify-version gate, WINDOWS_SIGNING_ENABLED skip-gate, OIDC federation, draft-Release flow, and all Linux/macOS jobs are unchanged. - janitor-gui/msix/AppxManifest.xml + Janitor.appinstaller: new. Publisher hardcoded to the Trusted Signing cert Subject (load-bearing); version templated @Version@ -> X.Y.Z.0 in CI. The .appinstaller omits all automatic UpdateSettings - manual-only, zero background egress (ADR 0034 Decisions 3+6). - janitor-gui/Cargo.toml: drop [package.metadata.packager.nsis]. - docs/RELEASING.md, docs/THREAT-MODEL.md: document the MSIX update model, the 0.1.3-NSIS bootstrap gap (open the .appinstaller), and the new manual-only network update / remote-code-install surface. - .gitignore: dist/. Locally validated: makeappx pack succeeds against the real Publisher + built exe (schema-validates the manifest). Not yet exercised in CI (the windows job is skip-gated) and end-to-end update is unproven pending two live signed releases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1 of 2 of the Windows auto-update work (ADR 0034): the MSIX packaging pipeline. Pivots the Windows artifact from cargo-packager NSIS
.exeto an MSIX that auto-updates via Windows' built-in App Installer, signed by the existing Azure Trusted Signing cert — no second/minisign key.What's in it
.github/workflows/release.yml—windowsjob rewritten: build exe → assemble pack layout →makeappx pack→ Trusted-Sign the.msix(filtermsix) → upload.msix+.appinstaller. Theverify-versiongate,WINDOWS_SIGNING_ENABLEDskip-gate, OIDC federation, draft-Release flow, and every Linux/macOS job are untouched.janitor-gui/msix/AppxManifest.xml+Janitor.appinstaller(new) — full-trust win32 MSIX.Publisherhardcoded to the Trusted Signing cert Subject (load-bearing — must match exactly or signing rejects). Version templated@VERSION@→X.Y.Z.0in CI. The.appinstalleromits all automaticUpdateSettings: manual-only, zero background egress (ADR 0034 Decisions 3 + 6).janitor-gui/Cargo.toml— drop[package.metadata.packager.nsis](superseded on Windows).docs/RELEASING.md/docs/THREAT-MODEL.md— the MSIX update model, the 0.1.3-NSIS bootstrap gap (users must open the.appinstaller, not the bare.msix, or updates never wire up), and the new manual-only network-update / remote-code-install surface..gitignore—dist/.Verification
makeappx packrun locally against the real Publisher CN + the real release binary → schema-validates the manifest (element ordering, namespaces, logo/exe references, Publisher DN). Exit 0.@VERSION@substitution renders valid XML (0.1.3 → 0.1.3.0).windowsjob isif: WINDOWS_SIGNING_ENABLED == 'true', soworkflow_dispatchskips it until the Azure vars + gate are set. The first gated run is the first CI exercise of the sign step.To turn it on (maintainer)
Set the
AZURE_*repo Variables +WINDOWS_SIGNING_ENABLED=true(seedocs/RELEASING.md). The cert Subject is already baked into the manifests.Not in this PR
Slice 2/2 — the in-app "Check for updates" button (the sole manual update trigger, a
#[cfg(windows)]WinRT wrapper + Slint control) — follows as a separate PR.🤖 Generated with Claude Code