ci(release): wire Azure Trusted Signing for Windows#86
Merged
Conversation
Replaces the #56 TODO in the gated Windows job with the real signing path: azure/login OIDC (federated, no stored secret) -> sign the NSIS installer with azure/trusted-signing-action. Documents the repo Variables an operator sets to flip WINDOWS_SIGNING_ENABLED on. Bumps janitor-gui to 0.1.1 so a v0.1.1 tag can drive a draft release that exercises the new signing step (v0.1.0 already tagged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A tag-pattern federated credential can't wildcard without preview flexible FICs, and those can't be smoke-tested (workflow_dispatch presents a branch subject, not a tag one). Scope to a GitHub Environment instead: the OIDC subject is repo:OWNER/REPO:environment:release regardless of trigger, so one credential covers every release tag and the auth is verifiable in ~30s. Adds oidc-smoke.yml (workflow_dispatch, environment: release) to verify the azure/login token exchange without the ~17-min Windows build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Auth is verified; the smoke no longer needs to auto-run on branch pushes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
#56TODO in the gated Windows release job with the real signing path:azure/loginOIDC (federated credential, no stored secret)azure/trusted-signing-actionRELEASING.mddocuments the repo Variables that flipWINDOWS_SIGNING_ENABLEDonBumps
janitor-guito0.1.1so thev0.1.1tag drives a draft release that exercises the signing step end-to-end (v0.1.0was already tagged).All Azure-side wiring is done: cert profile
CircuitStitch(Public Trust) under accountCircuit-Stitch(West US 2), app registration with arefs/tags/v*federated credential, and the Trusted Signing Certificate Profile Signer role assigned. Repo Variables set; gate is on.Test run: tag
v0.1.1(this branch's HEAD).Closes #56.
🤖 Generated with Claude Code