fix(web): preserve dotted schema keys when saving plugin config

[rpierce99]

Problem

The plugin config form posts form-data with dot-notation paths (e.g. leagues.fifa.world.enabled). The two helpers that resolve those paths — _get_schema_property and _set_nested_value in web_interface/blueprints/api_v3.py — split on every dot. When a schema key itself contains a dot (soccer league keys like fifa.world, eng.1, usa.1), the dotted key was mistaken for nested fifa → world objects:

• _get_schema_property("leagues.fifa.world.favorite_teams") returned None, so the field wasn't recognized as an array and the value was dropped/mistyped.
• _set_nested_value(cfg, "leagues.fifa.world.enabled", True) created a fabricated leagues["fifa"]["world"] branch and left the real leagues["fifa.world"] untouched.

Net effect: every per-league edit (enable, favorite teams, nested booleans) was silently discarded. The save wrote the unchanged config and the file came out byte-identical, so users saw no error but no change either. This affects every league, since they all use dotted keys.

The frontend already solved this for its JSON path (greedy longest-match in getSchemaProperty/dotToNested), but the server-rendered form posts form-data to this backend path, which was never fixed.

Fix

Both helpers now greedily match the longest path segment that exists in the schema (_get_schema_property) or in the config being updated (_set_nested_value), so leagues.fifa.world.* resolves to the real leagues["fifa.world"] object. This mirrors the existing frontend behavior. Plain nested paths (no dotted keys) are unaffected.

Tests

Adds test/web_interface/test_dotted_league_keys.py (6 cases): schema lookup for dotted keys and nested objects beneath them, value typing ("USA" → ["USA"]), writes landing in the real league (no fabricated branch), writes into a not-yet-present leaf, plus a guard that plain nested paths still work. Verified the dotted-key cases fail before this change and pass after; the plain-nesting guard passes both ways.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@rpierce99, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 4 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 30e2d26c-d678-4123-8d6e-cad28bb21668

📥 Commits

Reviewing files that changed from the base of the PR and between d22d0a3 and c6b2bdf.

📒 Files selected for processing (2)

• test/web_interface/test_dotted_league_keys.py
• web_interface/blueprints/api_v3.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}