Skip to content

Fix ambiguous lsblk behaviour in LUKS/LVM use cases#253

Open
olivermg wants to merge 1 commit into
Chrysostomus:masterfrom
olivermg:master
Open

Fix ambiguous lsblk behaviour in LUKS/LVM use cases#253
olivermg wants to merge 1 commit into
Chrysostomus:masterfrom
olivermg:master

Conversation

@olivermg

Copy link
Copy Markdown

Fixes #252

Adds

sed -r 's/^[^[:alnum:]]+//'

to relevant locations of lsblk usage in order to remove ambiguous behaviour in certain partition layouts (refer to issue #252 for more info).

Please double check this, as the use case that this patch has helped me with probably only used a certain portion of the patched lines. I've tried to fix this throughout all scripts (just found relevant lines in util-base.sh and util-disk.sh).

@Chrysostomus

Copy link
Copy Markdown
Owner

Thanks! However, the version on github is outdated, the development has moved to gitlab:

https://gitlab.manjaro.org/applications/manjaro-architect

If possible, could you provide the changes against that repo? Either way, I'll try to implement the fix once I get working hardware.

@olivermg

Copy link
Copy Markdown
Author

Sure, I'll file it over there :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Erroneous behaviour when using LVM on LUKS with certain partition layouts

2 participants