Skip to content

Track flashcard views from learn #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopheCode merged 3 commits into from
Jun 21, 2026
Merged

Track flashcard views from learn #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c8114b
Load flashcard progress on learn page
ChristopheCode Jun 21, 2026
b439701
Record learned verb views
ChristopheCode Jun 21, 2026
70051fa
Test learn flashcard view storage
ChristopheCode Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions learn.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ <h3 class="help-title">How to use</h3>

<script src="./script.js"></script>
<script src="./data/irregular-verbs.js"></script>
<script src="./flashcard-progress.js"></script>
<script src="./learn.js"></script>

</body>
Expand Down
1 change: 1 addition & 0 deletions learn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ function showNewVerb() {
);

currentVerb = filteredVerbs[randomIndex];
window.FlashcardProgress?.recordView(currentVerb);
verbPrompt.textContent = currentVerb.base;
restartProgressAnimation((countdown + 1) * 1000);

Expand Down
11 changes: 10 additions & 1 deletion tests/smoke.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,23 @@ test('Legal pages load and allow mobile zoom', async ({ page }) => {
}
});

test('Learn loads verbs and Next stays usable', async ({ page }) => {
test('Learn loads verbs, saves views, and keeps Next usable', async ({ page }) => {
const errors = trackPageErrors(page);

await page.goto(pageUrl('learn.html'));

await expect(page.locator('#verbPrompt')).not.toHaveText('');
await expect(page.locator('#nextButton')).toBeEnabled();

const progressRaw = await page.evaluate(() => window.localStorage.casualEnglishFlashcardProgress || null);
expect(progressRaw).not.toBeNull();

const progress = JSON.parse(progressRaw);
const firstEntry = Object.values(progress)[0];
expect(firstEntry.views).toBe(1);
expect(firstEntry.correct).toBe(0);
expect(firstEntry.wrong).toBe(0);

await page.locator('#nextButton').click();

await expect(page.locator('#verbPrompt')).not.toHaveText('');
Expand Down
Loading