feat: add app language selector#24
Merged
Merged
Conversation
Owner
Author
|
CI update after follow-up fixes:
Local verification remains:
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phoneLocaleBeacon.Context / translation note
The new language selector strings are translated contextually for every supported locale. The new locale files also include a first contextual pass for the core app shell/settings/share strings so the app can compile and route all supported languages through Flutter l10n. A native-speaker copy review is still recommended before store release, especially for less-used feature/paywall/screenshot strings.
Verification
/root/flutter-sdk/bin/flutter gen-l10npython3 -m json.toolfor all ARB filesPATH=/root/flutter-sdk/bin:$PATH dart analyze ./root/flutter-sdk/bin/flutter test test/features/settings/app_locale_settings_test.dartLocal verification limits
Full
flutter testis blocked in this VPS environment by:libsqlite3.sofor the existing Drift pre-made tile controller testIconDataas final, which breaks existingphosphor_flutter 2.1.0compilation in screenshot/web buildsThose blockers appear environment/dependency-related rather than introduced by this PR; the targeted locale test and analyzer pass.