feat(docx): background color on <mark> becomes highlight if css matches#90
Draft
Alexnortung wants to merge 1 commit into
Draft
feat(docx): background color on <mark> becomes highlight if css matches#90Alexnortung wants to merge 1 commit into
Alexnortung wants to merge 1 commit into
Conversation
|
@Alexnortung is attempting to deploy a commit to the Chipili's projects Team on Vercel. A member of the Team first needs to authorize it. |
Alexnortung
force-pushed
the
feat/highlight-mark
branch
from
8ac4246 to
4f9af02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft for setting highlight in docx based on
<mark>elements.I think it is reasonable that
<mark>elements becomes highlight in docx since that is the actual semantic meaning of a<mark>element.One problem though: doc only supports a few colors (or maybe only docx.js?).
One consideration. The
colornamespackage is already used in this project, we could use it as for this as well to normalize the values and simplify the switch.TODO: