Enhance Music Player card with better visuals and default songs - #23
Merged
Chintanpatel24 merged 1 commit intoJun 10, 2026
Merged
Conversation
Chintanpatel24
commented
Jun 10, 2026
Chintanpatel24
commented
Owner
- Improved SVG designs for all 4 player styles (90s, iPod, Cassette, Boombox) with gradients and glow effects
- Added a list of high-quality default songs (Lofi Hip Hop, etc.) used when no parameters are provided
- Enhanced clickability: the entire card now acts as a link to the song
- Sanity checks and code cleanup
- Improved SVG designs for all 4 player styles (90s, iPod, Cassette, Boombox) with gradients and glow effects - Added a list of high-quality default songs (Lofi Hip Hop, etc.) used when no parameters are provided - Enhanced clickability: the entire card now acts as a link to the song - Sanity checks and code cleanup Co-authored-by: Chintanpatel24 <216989679+Chintanpatel24@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the Music Player card to be more visually polished across all supported player styles and adjusts the API/renderer behavior to support sensible defaults when callers don’t provide song parameters.
Changes:
- Added a default-song list and updated the SVG generator to use defaults when no song info is provided.
- Redesigned the SVG markup/styles for the 90s, iPod, cassette, and boombox variants (gradients, glow, tweaked layout).
- Updated
/api/musicto pass query parameters through without forced placeholder defaults (so the renderer can decide fallbacks).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/svg-music.js |
Adds default song support and substantially revamps SVG visuals/layout across all player styles. |
api/music.js |
Stops injecting placeholder defaults for title/artist/track_id, delegating default behavior to the SVG generator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+37
| let { title, artist, track_id, gif_url } = options; | ||
|
|
||
| // Use default song if none provided | ||
| if (!title && !artist && !track_id) { | ||
| const defaultSong = DEFAULT_SONGS[0]; |
Comment on lines
+95
to
99
| <a href="${trackUrl}" target="_blank"> | ||
| <path d="M-5 -5 L8 0 L-5 5 Z" fill="#555" transform="translate(0,0)"/> | ||
| <circle r="40" fill="transparent"/> | ||
| </a> | ||
| </g> |
Comment on lines
236
to
237
| </g> | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.