Skip to content

fix: initialize TEMP_LOG before conditional to prevent unbound variab… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChiefGyk3D merged 2 commits into from
Mar 20, 2026
Merged

fix: initialize TEMP_LOG before conditional to prevent unbound variab… #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
728feb6
fix: initialize TEMP_LOG before conditional to prevent unbound variab…
ChiefGyk3D Mar 20, 2026
58a1f32
fix: align notification title/status with actual update availability
ChiefGyk3D Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 38 additions & 5 deletions update-notifier.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,25 @@ elif [[ "$OS_TYPE" == "rhel" ]]; then
fi

# Read recent log entries and analyze what happened
TEMP_LOG=""
PLAIN_SUMMARY=""
if [[ ! -f "$LOG_FILE" ]]; then
log "WARNING: Log file $LOG_FILE not found. Sending notification anyway."
LOG_OUTPUT="Log file not found at $LOG_FILE"
UPDATE_STATUS="unknown"
UPDATE_SUMMARY="Log file not available"
if [[ "$AVAILABLE_UPDATES" -gt 0 ]]; then
UPDATE_STATUS="updates-available"
UPDATE_SUMMARY="${AVAILABLE_UPDATES} non-security package(s) available"
PLAIN_SUMMARY="📦 Updates Available: ${AVAILABLE_UPDATES} non-security packages\n Packages: ${AVAILABLE_PACKAGES}"
if [[ "$AVAILABLE_UPDATES" -gt 10 ]]; then
PLAIN_SUMMARY="${PLAIN_SUMMARY}... and $((AVAILABLE_UPDATES - 10)) more"
fi
PLAIN_SUMMARY="${PLAIN_SUMMARY}\nℹ️ No unattended-upgrades history yet (first run)"
else
UPDATE_STATUS="no-updates"
UPDATE_SUMMARY="System is up to date"
PLAIN_SUMMARY="✅ System is up to date\nℹ️ No unattended-upgrades history yet (first run)"
fi
LOG_OUTPUT=$(echo -e "$PLAIN_SUMMARY" | python3 -c "import sys, json; print(json.dumps(sys.stdin.read())[1:-1])" 2>/dev/null || \
echo -e "$PLAIN_SUMMARY" | awk '{gsub(/\\/,"\\\\",$0); gsub(/"/,"\\\"",$0); gsub(/\t/,"\\t",$0); printf "%s ", $0}' | sed 's/[[:cntrl:]]//g')
else
# Create a snapshot to avoid race conditions with active logging
TEMP_LOG=$(mktemp)
Expand Down Expand Up @@ -428,6 +442,9 @@ else
if [[ -z "$HUMAN_SUMMARY" ]]; then
HUMAN_SUMMARY="✅ Update check completed successfully"
fi

# Store plain-text summary for Matrix reuse
PLAIN_SUMMARY="$HUMAN_SUMMARY"

# Prepare for JSON (safely escaped)
LOG_OUTPUT=$(echo -e "$HUMAN_SUMMARY" | python3 -c "import sys, json; print(json.dumps(sys.stdin.read())[1:-1])" 2>/dev/null || {
Expand All @@ -446,13 +463,25 @@ if [[ "$UPDATE_STATUS" == "updated" ]] && [[ -z "$UPGRADED_PACKAGE_NAMES" ]] &&
log "INFO: Corrected status - no packages were actually upgraded this run"
fi

# Promote status when non-security updates are available but no security updates applied
if [[ "$UPDATE_STATUS" == "no-updates" ]] && [[ "$AVAILABLE_UPDATES" -gt 0 ]]; then
UPDATE_STATUS="updates-available"
UPDATE_SUMMARY="${AVAILABLE_UPDATES} non-security package(s) available"
log "INFO: Promoting status - ${AVAILABLE_UPDATES} non-security packages available"
fi

# Set notification title and description based on status
case "$UPDATE_STATUS" in
"updated")
NOTIFICATION_TITLE="System Updates Applied on $HOSTNAME"
NOTIFICATION_DESC="$UPDATE_SUMMARY at **$LAST_RUN**"
NOTIFICATION_COLOR=5814783 # Green
;;
"updates-available")
NOTIFICATION_TITLE="System Updates Available on $HOSTNAME"
NOTIFICATION_DESC="$UPDATE_SUMMARY at **$LAST_RUN**"
NOTIFICATION_COLOR=16744272 # Orange
;;
"no-updates")
NOTIFICATION_TITLE="System Update Check Complete on $HOSTNAME"
NOTIFICATION_DESC="$UPDATE_SUMMARY at **$LAST_RUN**"
Expand Down Expand Up @@ -703,9 +732,13 @@ if [[ "$MATRIX_CONFIGURED" == true ]]; then
MATRIX_SUMMARY="${MATRIX_SUMMARY}\n❌ Error: ${ERROR_MSG}"
fi

# Default if nothing was found
# Default if nothing was found - fall back to pre-computed summary
if [[ -z "$MATRIX_SUMMARY" ]]; then
MATRIX_SUMMARY="✅ Update check completed successfully"
if [[ -n "$PLAIN_SUMMARY" ]]; then
MATRIX_SUMMARY="$PLAIN_SUMMARY"
else
MATRIX_SUMMARY="✅ Update check completed successfully"
fi
fi

MATRIX_LOG=$(echo -e "$MATRIX_SUMMARY")
Expand Down
Loading