Conversation
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- add a repository-local CRIEW skill that points future work at the repo guidelines - require Signed-off-by trailers and large-commit bullet bodies in hooks and CI - document the commit policy in the English and Chinese guideline files Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- add UiKeymap enum (Default / Vim) to RuntimeConfig and config parser - implement vim-style h/l focus + j/k navigation alongside default i/k + j/l - wire keymap into input handler, render footer shortcuts, and config palette - add config set/get support for ui_keymap with live keymap switching Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
[Feat] configurable main page keymaps
- print the active ui_keymap value in criew doctor so users can verify their config file keymap setting is loaded correctly Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- add config_get_ui_keymap_returns_current_value to verify palette reports the active keymap value correctly - add loaded_vim_keymap_drives_navigation_keys to verify vim-mode j/k navigation and confirm default-mode i key does not trigger movement Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
fix(doctor): include ui_keymap in doctor output
- add IMAP doctor probing and archive sync behavior covered by the new tests - extend patch, sendmail, and TUI regression coverage across mailbox workflows - harden temporary command execution against transient executable-busy failures Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- group repository docs under architecture, development, milestones, reference, and specs - update README and repository skill references to the new paths - keep docs root ready for a future docs/wiki subtree Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- queue palette and mailbox-open sync requests onto background workers so the TUI stays responsive - close the command palette after sync commands are queued so status updates remain visible on the main screen - render footer sync progress for startup, manual, and auto-sync states so users can track background activity Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- split background-sync TUI regression coverage out from the feature implementation commit - add manual-sync state-machine coverage for duplicate requests, busy workers, failures, disconnects, and completion refresh - add non-blocking mailbox-open, sync palette dismissal, and footer progress rendering coverage for startup, manual, and auto-sync states Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
[Feat] configurable-main-page-keymaps
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
fix(reply): stabilize draft path for send-email
- add the custom ui.keymap value and keep its navigation fallback aligned with default bindings - render the active keymap in the header and surface the new option in config help and docs - add regression coverage for custom keymap loading and header rendering Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- warn when a reply draft has no authored content and highlight authored lines in preview - render send preview and reply notices as view switches within the reply panel area - add TUI regression coverage for preview styling, panel switching, and confirmation flow Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- add gg/G jumps and qq quit chords across the mail and code-browser panes - scope pending vim chords to the active pane and clear them when modal surfaces take focus - clamp preview and source scrolling so Shift+G stays render-safe, and document/test the workflow Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- focus the threads pane when Enter opens a mailbox from subscriptions, including cached and syncing paths - focus the preview pane when Enter opens the selected thread so the mail workflow advances forward - add regression coverage for subscription and thread Enter transitions plus non-blocking inbox cases Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- add scoped numeric prefixes for repeated vertical movement on the main page in default/custom and vim keymaps - clear pending counts when focus changes or modal surfaces take over so prefixes do not leak across interactions - document the count shortcuts and add TUI regression coverage for counted moves and scope resets Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
Improve interaction logic, panne switch, add keymap
- label editable reply headers and read-only thread metadata in the reply panel - open the reply panel with focus on From and keep docs/tests aligned Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- persist subscriptions and preview pane widths in ui-state.toml
- support expanding and shrinking mail panes with [ ] and { }
- add TUI regression tests and update user-facing shortcut docs
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- add the docs/wiki submodule, local MkDocs build scripts, and a GitHub Pages workflow for wiki publishing - add cargo wiki commands through xtask and document the local wiki lint/build flow in the README files - add the CRIEW wiki authoring skill and record the rewritten wiki home page commit in the submodule pointer Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- advance docs/wiki to include the expanded configuration and keybinding reference - include the remaining install, patch/reply, development, and contribution wiki pages Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- shorten the README files into wiki-first project entry points and update issue and PR templates - add the missing config example notes and the wiki submodule commit reminder in the authoring skill - switch the local wiki site requirements and MkDocs theme to mkdocs-material Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- add a :keymap editor for main-page navigation presets and custom bindings - persist ui.keymap_base and ui.custom_keymap settings with runtime validation - refresh TUI docs and regression tests for scheme isolation and active binding display Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
- bump the crate and lockfile version to 0.0.2 - note the current v0.0.2 release in the README entry pages - update the pinned docs/wiki submodule commit for the release docs Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84bb77a81c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+143
to
+145
| if not PurePosixPath(target_body).suffix: | ||
| candidate_paths.append(PurePosixPath(f"{target_body}.md")) | ||
|
|
There was a problem hiding this comment.
normalize_local_markdown_target treats both .md and .markdown files as markdown elsewhere, but when a link target has no suffix it only tries appending .md. As a result, links like [Guide](Guide) will not be rewritten when the destination file is Guide.markdown, leaving unresolved links in staged docs and causing broken navigation (or strict MkDocs link errors) for that page set.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the intent of this change and the user-visible outcome.
Related Issues
Link issues if applicable.
What Changed
Testing
List what you ran locally.
Documentation
Checklist
develop, I usedrebaseto resolve itNotes For Reviewers
Anything that needs special attention during review.