Add logging - #13
Open
CharlieCumber wants to merge 2 commits into
Open
Conversation
BenRamchandani
left a comment
BenRamchandani
left a comment
There was a problem hiding this comment.
The logging looks good. If you wanted to go further you could set it up to log requests and maybe log warnings when a reader tries to do something they don't have permissions for.
You've broken your tests though. I'll accept this in Aptem, just don't make a habit of raising PRs with broken tests/CI on real projects!
Ideally fix the tests, but go ahead and merge when you're ready.
Comment on lines
+33
to
+35
| variable "LOGGLY_TOKEN" { | ||
| description = "Customer access token for loggly subscription" | ||
| } |
There was a problem hiding this comment.
Suggested change
| variable "LOGGLY_TOKEN" { | |
| description = "Customer access token for loggly subscription" | |
| } | |
| variable "LOGGLY_TOKEN" { | |
| description = "Customer access token for loggly subscription" | |
| sensitive = true | |
| } |
| handler.setFormatter( | ||
| Formatter("[%(asctime)s] %(levelname)s in %(module)s: %(message)s") | ||
| ) | ||
| app.logger.addHandler(handler) |
There was a problem hiding this comment.
This crashes if LOGGLY_TOKEN is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.