Skip to content

Using enum's to represent currency#4

Open
abrishk26 wants to merge 2 commits into
Chapa-Et:mainfrom
abrishk26:main
Open

Using enum's to represent currency#4
abrishk26 wants to merge 2 commits into
Chapa-Et:mainfrom
abrishk26:main

Conversation

@abrishk26

Copy link
Copy Markdown

Pull Request

Short description

  • What: Changed the currency fields on different structs to Currency enum.
  • Why: Using enums makes it clear instead of strings in this case.
  • How: Changed the fields to use Currency enum from the bank module.

Checklist

  • [ ☑] PR targets the correct branch
  • [☑ ] Code compiles without errors
  • Tests added/updated or not applicable
  • CI passes
  • Docs/CHANGELOG updated if needed
  • [ ☑] PR follows Conventional Commits (feat:, fix:, docs:, etc.)

Related

Testing

  • Run: make check
  • Notes: add any manual steps if required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant