Chloe/inventory schema#15
Conversation
Co-authored-by: draw-n <drawnformoney@gmail.com> Co-authored-by: Kai Dubauskas <kaidubauskas@gmail.com>
* added Order schema * made basic order controller functions * Revert "made basic order controller functions" This reverts commit c16383b. * changed Order.ts according to comments
* added Order schema * made basic order controller functions * Revert "made basic order controller functions" This reverts commit c16383b. * created basic order controller functions * updated Order.ts to reflect prior merge --------- Co-authored-by: Kai Dubauskas <kaidubauskas@gmail.com>
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 8644087 | Google Cloud Keys | d2089d7 | config/serviceAccountKey.json | View secret |
| 8644087 | Google Cloud Keys | 9fd60a3 | config/serviceAccountKey.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
KaiDubauskas
left a comment
KaiDubauskas
left a comment
There was a problem hiding this comment.
This all looks fine, but Im not sure why there's 15 files that have been changed from .idea. Can't say what went wrong, but if you could make a new PR request but only push the necessary model and controller files. (ie when git adding, only add these files by name)
4 participants
Added Inventory Schema. This should resolve the secret and merge conflict errors