Skip to content

Draft extension for SPZ compression support for Gaussian splats#81

Closed
keyboardspecialist wants to merge 33 commits into
3d-tiles-nextfrom
draft-spz-splat-compression
Closed

Draft extension for SPZ compression support for Gaussian splats#81
keyboardspecialist wants to merge 33 commits into
3d-tiles-nextfrom
draft-spz-splat-compression

Conversation

@keyboardspecialist

@keyboardspecialist keyboardspecialist commented Apr 17, 2025

Copy link
Copy Markdown

Follows EXT_draco_mesh_compression as pattern.

weegeekps
weegeekps reviewed Apr 17, 2025
View reviewed changes
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_compression/README.md Outdated
lilleyse
lilleyse reviewed Apr 21, 2025
View reviewed changes

@lilleyse lilleyse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few comments from me.

Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread ...ian_splats_compression/schema/mesh.primitive.KHR_spz_gaussian_splats_compression.schema.json Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
weegeekps and others added 12 commits April 21, 2025 14:11
@weegeekps @lilleyse
Update extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/REA…
d5148cc 
…DME.md

Co-authored-by: Sean Lilley <lilleyse@gmail.com>
@weegeekps @lilleyse
Update extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/REA…
b4b4d56 
…DME.md

Co-authored-by: Sean Lilley <lilleyse@gmail.com>
@weegeekps @lilleyse
Update extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/REA…
403ebe7 
…DME.md

Co-authored-by: Sean Lilley <lilleyse@gmail.com>
@weegeekps @lilleyse
Update extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/REA…
9d5240f 
…DME.md

Co-authored-by: Sean Lilley <lilleyse@gmail.com>
@weegeekps
Added note that _ROTATION is a quaternion.
b84ceae
@keyboardspecialist
Corrected color attribute description and component type
7cead84
@weegeekps
Schema updates
51a9b23
@weegeekps
Merge remote-tracking branch 'origin/3d-tiles-next' into draft-spz-sp…
7ea1c58 
…lat-compression
@weegeekps
Updated extension name in schema
8b79ea0
@weegeekps
Made some fields required.
6afc50b
@weegeekps
SPZ handles versioning itself.
1e94efb
@weegeekps
Revert "Merge remote-tracking branch 'origin/3d-tiles-next' into draf…
965f573 
…t-spz-splat-compression"

This reverts commit 7ea1c58, reversing
changes made to 51a9b23.
@weegeekps

weegeekps commented May 15, 2025

Copy link
Copy Markdown
Collaborator

I did something I shouldn't have and managed to completely pollute the history for this branch. I will try to clean it up later.

@lilleyse - when you have a moment another review pass is appreciated.

weegeekps
weegeekps reviewed May 15, 2025
View reviewed changes
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Comment on lines +131 to +140
"max": [
1,
1,
1,
],
"min": [
-1,
-1,
-1,
]

@weegeekps weegeekps May 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required by the glTF spec for all POSITION accessors.

In reality, we should probably calculate the actual bounds, but right now this is good enough since we don't need them for implementation.

A good ask for the working group is if we can relax this requirement when our extension is in use.

@weegeekps weegeekps May 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good ask for the working group is if we can relax this requirement when our extension is in use.

I changed my mind about this. I think there's still potential for these bounds to be very useful in some engines. We should still require these bounds to be properly calculated.

@lilleyse lilleyse changed the base branch from main to 3d-tiles-next May 16, 2025 15:26
@lilleyse lilleyse changed the base branch from 3d-tiles-next to main May 16, 2025 15:27
@lilleyse lilleyse changed the base branch from main to 3d-tiles-next May 16, 2025 15:30
@lilleyse

lilleyse commented May 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I was able to fix the history by

  • merging main into 3d-tiles-next
  • merging 3d-tiles-next into this branch
  • changing the target branch to 3d-tiles-next
  • Adding back the 3d-tiles-next files that were removed

Though none of this will matter once a PR is opened in the Khronos repo (at least I don't see the need to keep the commit history)

lilleyse
lilleyse reviewed May 16, 2025
View reviewed changes

@lilleyse lilleyse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments from me. I like how simple the extension schema is now.

Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
Comment thread extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md Outdated
@weegeekps weegeekps mentioned this pull request May 16, 2025
Closed
weegeekps and others added 4 commits May 16, 2025 11:08
@weegeekps @lilleyse
Fix spherical harmonic type
ae80005 
Co-authored-by: Sean Lilley <lilleyse@gmail.com>
@weegeekps @lilleyse
Fix number of points statement
3c4fc07 
Co-authored-by: Sean Lilley <lilleyse@gmail.com>
@weegeekps
Clarification around accessors
d615071
@weegeekps
Updated authors
a4d8821
@weegeekps

weegeekps commented May 22, 2025

Copy link
Copy Markdown
Collaborator

I'm going to close this PR and create a new branch cherry picked from this one. While Sean fixed the issue for our review purposes, my mishap still creates quite a mess for a PR into the official glTF repo.

@weegeekps weegeekps closed this May 22, 2025
@weegeekps

weegeekps commented May 22, 2025

Copy link
Copy Markdown
Collaborator

Reopened in the Khronos Group glTF repo: KhronosGroup#2490

@GISUser1

GISUser1 commented Jul 8, 2025

Copy link
Copy Markdown

GISBox now fully supports the KHR_spz_gaussian_splats_compression slicing function. This feature, through an innovative slicing compression algorithm, significantly improves the transmission efficiency and rendering performance of Gaussian splatting point cloud data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weegeekps weegeekps weegeekps left review comments
@lilleyse lilleyse lilleyse left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keyboardspecialist @weegeekps @lilleyse @GISUser1