Enables coloring of ModelExperimental#9881
Merged
Merged
Conversation
|
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
added 2 commits
October 20, 2021 14:39
…mGS/cesium into model-experimental-color
ptrgags
reviewed
Oct 20, 2021
ptrgags
left a comment
ptrgags
left a comment
Contributor
There was a problem hiding this comment.
@sanjeetsuhag looks pretty solid overall, though it doesn't seem to work with instancing or the TriangleWithoutIndices? is this supposed to happen?
…experimental-color
Contributor
Author
@ptrgags and I compared with the
|
Contributor
Author
ptrgags
reviewed
Oct 22, 2021
ptrgags
left a comment
ptrgags
left a comment
Contributor
There was a problem hiding this comment.
@sanjeetsuhag really close, though now I think we need to double check the REPLACE color mode.
Contributor
|
@sanjeetsuhag looks good, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
color,colorBlendAmountandcolorBlendModetoModelExperimental.Sandcastle for setting
color,colorBlendAmount,colorBlendModeonModelExperimentalDepends on #9873 being merged first.