Release/local#136
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f09a4f4b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| skills: list[dict[str, str]] = [] | ||
| blockers: list[dict[str, object]] = [] | ||
| for skill_dir in managed_directories(runtime_root): | ||
| manifest, error = read_manifest(skill_dir) |
There was a problem hiding this comment.
Handle non-UTF8 manifests as inventory blockers
When --inventory encounters a direct manifest file that exists but is not valid UTF-8, this new inventory loop lets read_manifest() raise UnicodeDecodeError, so the global inventory command exits with a traceback instead of the compact blocker JSON promised for malformed direct manifests. This means one corrupted .runtime-manifest.json can prevent the automation from enumerating the remaining valid skills; catch UnicodeError on this path and report it like the existing unreadable-manifest blocker.
AGENTS.md reference: AGENTS.md:L84-L86
Useful? React with 👍 / 👎.
Changes
Validation
npm cinpm run lint:markdownpython -m pip install -r requirements-dev.txtpython -m yamllint .python -m mypypython skills/ceratops-skill-lifecycle/scripts/skills-consistency-source-validator.py --mode fullRelease impact