Skip to content

[ENG-11516] Eliminate the request between metadata and download#490

Merged
cslzchen merged 4 commits into
CenterForOpenScience:feature/improve-daz-phase2from
antkryt:feature/ENG-11516
Jul 7, 2026
Merged

[ENG-11516] Eliminate the request between metadata and download#490
cslzchen merged 4 commits into
CenterForOpenScience:feature/improve-daz-phase2from
antkryt:feature/ENG-11516

Conversation

@antkryt

@antkryt antkryt commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://openscience.atlassian.net/browse/ENG-11516

Purpose

Pass storage meta to provider download method

Changes

Side effects

QA Notes

Deployment Notes

@cslzchen cslzchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and will merge after local verification.

@cslzchen cslzchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review this PR with local testing and raised two questions 🔥

Comment thread waterbutler/providers/osfstorage/provider.py Outdated
Comment thread waterbutler/providers/osfstorage/provider.py

@cslzchen cslzchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread waterbutler/providers/osfstorage/provider.py Outdated
Comment thread waterbutler/providers/osfstorage/provider.py Outdated
Comment thread waterbutler/providers/osfstorage/provider.py
@cslzchen
cslzchen merged commit 97a0b84 into CenterForOpenScience:feature/improve-daz-phase2 Jul 7, 2026
2 checks passed
cslzchen added a commit that referenced this pull request Jul 17, 2026
* [ENG-11344] Add `minimal` query parameter to zip and metadata methods in OSFStorageProvider (#483)
* [ENG-11352] Enhance ZipStreamGenerator to accept additional keyword arguments for metadata retrieval (#484)
* [ENG-11354] WB: Unit tests - Part 1 (#485)
* [ENG-11468] Improve output zip file name from DAZ (#486)
* [ENG-11485] Update WB to use pagination from the updated metadata endpoint for OSFStorage Zip (#487)
* [ENG-11515] Async and cache metadata requests (#488)
* [ENG-11517] Update WB pagination to use async/cache metadata (#489)
* [ENG-11516] Eliminate the request between metadata and download (#490)
* [ENG-11565] Unit Tests - Part 2 (#491)
* [ENG-11581] Update WB to use the best option by default (#493)

---------

Co-authored-by: Ostap-Zherebetskyi <ozherebetskyi@exoft.net>
Co-authored-by: antkryt <ant.krytskyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants