Skip to content

[ENG-11761] Add password length restriction #11811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkovalua wants to merge 2 commits into
base: feature/pbs-26-13
Choose a base branch
from
+23 −1
Open

[ENG-11761] Add password length restriction #11811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e11fc79
Add password length restriction to UserResetPasswordSerializer with 2…
mkovalua Jul 15, 2026
08f170a
Update test_user_settings_reset_password.py
mkovalua Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/users/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ class Meta:
class UserResetPasswordSerializer(BaseAPISerializer):
uid = ser.CharField(write_only=True, required=True)
token = ser.CharField(write_only=True, required=True)
password = ser.CharField(write_only=True, required=True)
password = ser.CharField(write_only=True, required=True, max_length=255)

class Meta:
type_ = 'user_reset_password'
Expand Down
22 changes: 22 additions & 0 deletions api_tests/users/views/test_user_settings_reset_password.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,28 @@ def test_post_invalid_password(self, app, url, user_one, csrf_token):
res = app.post_json_api(url, payload, expect_errors=True, headers={'X-THROTTLE-TOKEN': 'test-token', 'X-CSRFToken': csrf_token})
assert res.status_code == 400

def test_post_password_too_long(self, app, url, user_one, csrf_token):
app.set_cookie(CSRF_COOKIE_NAME, csrf_token)
encoded_email = urllib.parse.quote(user_one.email)
url = f'{url}?email={encoded_email}'
from tests.utils import capture_notifications

with capture_notifications():
res = app.get(url)
user_one.reload()
payload = {
'data': {
'attributes': {
'uid': user_one._id,
'token': user_one.verification_key_v2['token'],
'password': 'a' * 256,
}
}
}

res = app.post_json_api(url, payload, expect_errors=True, headers={'X-THROTTLE-TOKEN': 'test-token', 'X-CSRFToken': csrf_token})
assert res.status_code == 400 and res.json['errors'][0]['detail'] == 'Ensure this field has no more than 255 characters.'

def test_throttle(self, app, url, throttle_user, csrf_token):
app.set_cookie(CSRF_COOKIE_NAME, csrf_token)
encoded_email = urllib.parse.quote(throttle_user.email)
Expand Down