[ENG-11702][ENG-11694][ENG-11699][ENG-11703] Notification Campaign Admin Page#11808
Merged
Conversation
Ostap-Zherebetskyi
changed the title
cslzchen
approved these changes
Jul 15, 2026
cslzchen
left a comment
cslzchen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good with suggestions for filters and validation, which will be taken care of in a different ticket/PR 🔥 .
Comment on lines
+207
to
+213
| recipients_qs_annotated = recipients_qs.annotate( | ||
| recipient_address=Case( | ||
| When(username__contains='@', then='username'), | ||
| default=Subquery(first_email_subquery), | ||
| output_field=CharField(), | ||
| ) | ||
| ) |
Collaborator
There was a problem hiding this comment.
Note for future improvement, have a new status "not applicable" or "no email", no retry, not count as failed.
cslzchen
marked this pull request as ready for review
July 15, 2026 15:34
cslzchen
merged commit Jul 15, 2026
fd6f778
into
CenterForOpenScience:feature/project-enter
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Changes
Notification Campaign Admin Page
Side Effects
QE Notes
CE Notes
Documentation