[ENG-8655] - Add a new page for pending preprint moderation#11284
Closed
Vlad0n20 wants to merge 2 commits into
Closed
[ENG-8655] - Add a new page for pending preprint moderation#11284Vlad0n20 wants to merge 2 commits into
Vlad0n20 wants to merge 2 commits into
Conversation
opaduchak
suggested changes
Sep 15, 2025
opaduchak
left a comment
opaduchak
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I have one minor question
| from framework.auth import Auth | ||
| auth = Auth.from_kwargs(request.args.to_dict(), {}) | ||
| if not preprint.can_view(auth): | ||
| if getattr(preprint, 'is_pending_moderation', True): |
Contributor
There was a problem hiding this comment.
is this necessary? Can't it be simplified to
Suggested change
| if getattr(preprint, 'is_pending_moderation', True): | |
| if preprint.is_pending_moderation: |
opaduchak
approved these changes
Sep 16, 2025
Vlad0n20
changed the base branch from
feature/pbs-25-16
to
feature/pbs-25-19
September 18, 2025 14:14
Vlad0n20
force-pushed
the
fix/ENG-8655
branch
from
September 19, 2025 16:37
13f6170 to
f7a4a77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8655?atlOrigin=eyJpIjoiNWEyY2Q5MjVkMDcwNDczYWJjZmZkMmY1NWIyNzVlMjEiLCJwIjoiaiJ9